Deterministic for loops for dictionaries.
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2018
Merged
djbe
force-pushed
the
feature/swift4.2
branch
from
2dd1311
to
9c408d4
Compare
djbe
force-pushed
the
feature/deterministic-for-loop
branch
from
9dbab92
to
a3da20c
Compare
ilyapuchka
approved these changes
Sep 20, 2018
|
I think it's fine though I don't think this was mentioned anywhere in docs (I mean Stencil) that on dictionaries the order sill be deterministic. But this will preserve current behaviour at least. |
|
I think end users would expect consistent behaviour, no matter what the underlying (Swift) behaviour might be? |
|
And with the new swift hashing, we're forced to do something ourselves in this case. |
|
🤷♂️ depends on user understanding of nature of such types =) for some deterministic order in swift < 4.2 could be a surprise too =) |
|
@ilyapuchka I inadvertently merged this into the wrong branch 🤦♂️, so we should continue our discussion in #242. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Swift 4.2, hashing isn't consistent between runs anymore. A consequence of this is, if we iterate over a dictionary, the output won't always be the same, which will be unexpected for a user.
With this PR we iterate over the sorted keys of a dictionary, ensuring consistent output across runs.